[PATCH] D120102: [HWASAN] Add test for optnone function.

[Florian Mayer via Phabricator via llvm-commits]

fmayer added inline comments.


================
Comment at: llvm/test/Instrumentation/HWAddressSanitizer/use-after-scope.ll:115
+; NOSCOPE-NEXT:    br i1 [[TMP10]], label [[TMP11:%.*]], label [[TMP9]]
+; NOSCOPE:       11:
+; NOSCOPE-NEXT:    call void @use(i8* nonnull [[ALLOCA_0_HWASAN]])
----------------
fmayer wrote:
> eugenis wrote:
> > Should this say `[[TMP11]]`? It is otherwise unused.
> > 
> > Overall I feel this test is too detailed and potentially brittle. If you want to check that tagging/untagging happens within lifetime bounds, that can be done with just a few lines.
> > 
> > Also, I could be misreading, but does this show __hwasan_tag_memory after lifetime.end?
> This is copy-pasted from the test just above, just with added _optnull.
Rebased this to a CL that fixes this problem. PTAL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120102/new/

https://reviews.llvm.org/D120102