[PATCH] D120733: [IRSim][IROutliner] Ignore outlined sections that include musttail calls

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/IROutliner.h:384
+        return false;
+      // The outliner can only handle musttail items if it is also accompanied
+      // by the tailcc or swifttailcc calling convention.
----------------
Could be removed from this version, is needed in the patch that handles outlining musttail calls.


================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:1203
+                                        MatchCallsByName, !DisableIntrinsics,
+                                        false));
   return false;
----------------
Needs Comment to denote the argument name.


================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:1222
+                                     MatchCallsByName, !DisableIntrinsics,
+                                     false);
   IRSI.findSimilarity(M);
----------------
Needs Comment to denote the argument name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120733/new/

https://reviews.llvm.org/D120733