[PATCH] D120584: [NewPM][Inliner] Mark inlined calls to functions in same SCC as callee as noinline

Tue Mar 1 05:44:29 PST 2022

nikic added inline comments.

================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:942
+              if (CG.lookupSCC(CG.get(Callee)) ==
+                  CG.lookupSCC(CG.get(*NewCallee))) {
+                ICB->addFnAttr(Attribute::NoInline);
----------------
Shouldn't we also check `&& CG.lookup(CG.get(*NewCallee)) != C` here? We do want to allow this if caller, the callee and the new callee are all in the same SCC, right? If everything is one SCC, then the inlining is size-limited through the usual mechanism.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120584/new/

https://reviews.llvm.org/D120584