[PATCH] D120677: [LLD] [COFF] Use StringTableBuilder to optimize the string table

Tue Mar 1 04:56:54 PST 2022

mstorsjo added a comment.

FWIW, D113866 <https://reviews.llvm.org/D113866> made the effect of this much smaller, by writing much less unnecessary symbols.

In D120677#3349959 <https://reviews.llvm.org/D120677#3349959>, @rnk wrote:

> The size improvements are entirely from string tail merging, right?

Yes, tail merging or plain deduplication.

> In any case, this looks good to me. Debug info and symbols are sufficiently large that it's worth taking the time to make it smaller where possible.

Ok, I’ll go ahead and push it soon then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120677/new/

https://reviews.llvm.org/D120677