[PATCH] D120645: [Object] Skip section offset checking for /<XFGHASHMAP>/

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

I’m not entirely clear about the big picture here… The real Windows SDK library files contain members that cause us to error out (for some reason), and we choose to just skip those members, to avoid erroring out.

To test this, we artificially create libraries with a member named like this (but which is a real regular object file), and we check that we ignore it. But the test doesn’t replicate the aspect of the real files that made us error out on them to begin with, right? So the testcase can’t be used for testing other ways of dealing with the root cause, other than ignoring - is that right?

(I’m not saying the it has to be done differently, I’m just trying to get a grasp of the issue and what this tests.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120645/new/

https://reviews.llvm.org/D120645