[PATCH] D110714: [Flang][openmp] Added semantic checks for atomic construct with update clause

Nimish Mishra via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 03:24:22 PST 2022


NimishMishra added a comment.

In D110714#3350779 <https://reviews.llvm.org/D110714#3350779>, @peixin wrote:

> I noticed you landed this patch without addressing those code style issues I commented above such as https://github.com/llvm/llvm-project/blob/aeab6167b0a13ab3a46798c0a9929458e0413f08/flang/lib/Semantics/check-omp-structure.cpp#L632. Also, when you land the patch, you should add the commit message and the review link, which will close this PR for you automatically.
>
> Can you create one new NFC patch to fix them and close this PR?

Hi @peixin. Thanks for bringing this to attention. I actually addressed the comments through formatting. I must have made a mistake while landing it (which also didn't close this differential). I'll fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110714/new/

https://reviews.llvm.org/D110714



More information about the llvm-commits mailing list