[PATCH] D120665: [AArch64] Fix the TuneExynosM4 entry in lib/Target/AArch64/AArch64.td

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:821
 
-def TuneExynosM4 : SubtargetFeature<"exynosm3", "ARMProcFamily", "ExynosM3",
-                                    "Samsung Exynos-M3 processors",
+def TuneExynosM4 : SubtargetFeature<"exynosm4", "ARMProcFamily", "ExynosM3",
+                                    "Samsung Exynos-M4 processors",
----------------
dmgreen wrote:
> sdesmalen wrote:
> > should this be ExynosM4 as well then?
> It wasn't in the original code. They shared the ExynosM3 ProcFamily. Adding it doesn't add a huge amount unless there is some reason to distinguish the two.
Makes sense. Perhaps a comment would be useful in that case, e.g. `/*Re-uses ExynosM3 proc family*/` or something like that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120665/new/

https://reviews.llvm.org/D120665