[PATCH] D120708: [SCEV] Enable verification under EXPENSIVE_CHECKS

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 03:01:01 PST 2022


nikic created this revision.
nikic added reviewers: mkazantsev, reames.
Herald added subscribers: javed.absar, hiraditya.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

SCEV verification should no longer affect results of subsequent queries, and our lit tests as well as llvm-test-suite pass with SCEV verification enabled, so I think we can enable it by default under EXPENSIVE_CHECKS now.

Depends on D120551 <https://reviews.llvm.org/D120551>.


https://reviews.llvm.org/D120708

Files:
  llvm/lib/Analysis/ScalarEvolution.cpp


Index: llvm/lib/Analysis/ScalarEvolution.cpp
===================================================================
--- llvm/lib/Analysis/ScalarEvolution.cpp
+++ llvm/lib/Analysis/ScalarEvolution.cpp
@@ -148,8 +148,11 @@
 STATISTIC(NumFoundPhiSCCs,
           "Number of found Phi-composed strongly connected components");
 
-// FIXME: Enable this with EXPENSIVE_CHECKS when the test suite is clean.
+#ifdef EXPENSIVE_CHECKS
+bool llvm::VerifySCEV = true;
+#else
 bool llvm::VerifySCEV = false;
+#endif
 
 static cl::opt<unsigned>
 MaxBruteForceIterations("scalar-evolution-max-iterations", cl::ReallyHidden,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120708.412024.patch
Type: text/x-patch
Size: 606 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220301/f701205a/attachment.bin>


More information about the llvm-commits mailing list