[PATCH] D120651: [SCEV] Only verify BECounts for reachable loops (PR50523)

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:13465
+    // any BECount is legal.
+    if (!ReachableBlocks.contains(L->getHeader()))
+      continue;
----------------
mkazantsev wrote:
> Why not just use `DT->isReachableFromEntry(L->getHeader())`?
The problematic case is `br i1 false` style branches, for which you added special handling in isImpliedCond(). The blocks are reachable in the DT, which does not special-case constant branch conditions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120651/new/

https://reviews.llvm.org/D120651