[PATCH] D120645: [Object] Skip section offset checking for /<XFGHASHMAP>/

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D120645#3350478 <https://reviews.llvm.org/D120645#3350478>, @psamolysov-intel wrote:

> Thanks @jhenderson for the idea to use python to insert (or replace in my case) a section. I've updated the patch and added a test for the llvm-lib tool to list sections from a library with /<XFGHASHMAP>/. I've made a patch using the `git diff -U8000` command and I'm not sure the binary file (the library for the test) has been uploaded well. If not, could you share with me the required command to attach the binary content to the patch?

We try to avoid using canned binaries as test inputs. Could you generate an archive at test time, and then append the relevant bit using python then? There are a few examples in the lit testsuite of invoking python at test time to do various bits of manipulation.

FWIW, I don't believe you can upload a binary to Phabricator.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120645/new/

https://reviews.llvm.org/D120645