[PATCH] D120659: Cleanup includes: LLVMAnalysis

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D120659#3348770 <https://reviews.llvm.org/D120659#3348770>, @serge-sans-paille wrote:

> Sorry, this one is slightly longer than the others :-/

Assuming that you have tested BUILD_SHARED_LIBS=on, and built clang, clang-tools-extra, polly, and mlir.

I find that flang/lldb doesn't use llvm/Analysis, but building them may be useful for other directory cleanups.



================
Comment at: llvm/lib/Analysis/CallGraphSCCPass.cpp:41
 
+#ifdef EXPENSIVE_CHECKS
+#include "llvm/IR/StructuralHash.h"
----------------
Just uncondtionally include it? The header does `#ifdef EXPENSIVE_CHECKS` itself.


================
Comment at: llvm/lib/Analysis/RegionPass.cpp:24
 #include "llvm/Support/raw_ostream.h"
+#ifdef EXPENSIVE_CHECKS
+#include "llvm/IR/StructuralHash.h"
----------------
ditto

Or perhaps just revert this change


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120659/new/

https://reviews.llvm.org/D120659