[PATCH] D120622: [AArch64] Use correct calling convention for each vararg

Le Philousophe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 28 12:28:07 PST 2022


lephilousophe added a comment.

> This patch isn't making any codegen changes here, so clearly the backend can already handle this case.

In fact I just copied the piece of code from the `AArch64TargetLowering::LowerCall` function.
By doing this I believe I just make things consistent between whether the TCO could take place and when TCO is done.

Now a noob question related to your comments.
I read that there is now a clang attribute to mark calls as musttail. Isn't these checks necessary for the case where user can ask for a tail call when it's not possible?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120622/new/

https://reviews.llvm.org/D120622



More information about the llvm-commits mailing list