[PATCH] D120654: WoA: Change target triple & try_compile config

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D120654#3348840 <https://reviews.llvm.org/D120654#3348840>, @awarzynski wrote:

> However, the tests that @rovka is referring to are Flang's **frontend driver** unit tests. Neither the frontend driver nor the corresponding unit tests in Flang use `clangDriver`, so `aarch64-windows-msvc` is used verbatim and `windows` is parsed as vendor and `msvc` as OS.

I think the issue here, is that `LLVM_HOST_TRIPLE` is handled inconsistently in the codebase. When a user passes an explicit triple (e.g. via Clang's `--target`), it usually gets normalized before it's used. The use of `LLVM_HOST_TRIPLE` and similar is much more inconsistent though; in some cases in the codebase (in some tools), it works fine with a non-normalized triple, but others fail. I think we should move towards always normalizing the triples before they're used like that, even for the compiled-in hardcoded defaults, to make it behave the same as ones passed on the command line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120654/new/

https://reviews.llvm.org/D120654