[PATCH] D120477: [LoongArch] Add basic support to Disassembler

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

Overall LGTM, only a few minor issues.



================
Comment at: llvm/test/MC/LoongArch/ISA/Basic/Integer/invalid-dis.s:1
+# Test that disassembler rejects smaller data than 4 bytes.
+
----------------
typo, I think it should be "data smaller than 4 bytes"


================
Comment at: llvm/test/MC/LoongArch/Misc/aligned-nops.s:2
+# RUN: llvm-mc -filetype=obj -triple loongarch64 < %s \
+# RUN:     | llvm-objdump -d - | FileCheck -check-prefix=CHECK-INST %s
+
----------------
I don't think you should use a special check prefix since there is only one variant here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120477/new/

https://reviews.llvm.org/D120477