[PATCH] D83612: [NewPM][CodeGen] Add NPM support to llc
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 28 10:17:54 PST 2022
arsenm added inline comments.
Herald added subscribers: mstorsjo, pengfei.
================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:608
+ if (!StopBeforeOpt.empty())
+ *StopOpt = StopBeforeOpt;
+ if (!StopAfterOpt.empty())
----------------
Why not use a reference?
================
Comment at: llvm/tools/llc/NewPMDriver.cpp:50
+static cl::opt<RegAllocType> RegAlloc(
+ "regalloc2", cl::desc("Register allocator to use for new pass manager"),
+ cl::Hidden, cl::ValueOptional, cl::init(RegAllocType::Default),
----------------
Can't these be shared? Plus "2" isn't ideal naming
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83612/new/
https://reviews.llvm.org/D83612
More information about the llvm-commits
mailing list