[PATCH] D111419: [Demangle] Add support for D types back referencing

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:312
+  if (Backref == nullptr)
+    return nullptr;
+
----------------
RKSimon wrote:
> @ljmf00 coverity is warning that it looks like we fail to restore LastBackref if we early-return here - is that correct?
Out of curiosity, do you have the full/actual Coverity error? Is it detecting based on the "Save" prefix that the variable is intended to save/restore?

I'm guessing on this codepath we're probably on an error path anyway, and it doesn't matter if it's restored? 

But @ljmf00 could you confirm that that's the case and/or that this path (a LastBackref value, and a bail-out through this early return) is tested/behaving as desired?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111419/new/

https://reviews.llvm.org/D111419