[PATCH] D120545: [LoongArch] Add EncoderMethods for transformed immediate operands

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

With the nit, this looks good to me too, thanks!



================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCCodeEmitter.cpp:97
+
+  llvm_unreachable("Unhandled expression!");
+}
----------------
Not sure what's better here, `assert(MO.isImm())` or `llvm_unreachable`.

On the function above, you return 0 even after llvm_unreachable, but here you don't.

Is that because of compiler warnings? I believe this shouldn't be necessary, but I could be wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120545/new/

https://reviews.llvm.org/D120545