[PATCH] D119368: [UpdateLLCTestChecks] Add support for isel debug output in update_llc_test_checks.py
Sebastian Neubauer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 28 08:17:06 PST 2022
sebastian-ne added inline comments.
================
Comment at: llvm/test/tools/UpdateTestChecks/update_llc_test_checks/isel-support.test:1
+## Basic test checking that update_llc_test_checks.py can update a file with isel debug output
+
----------------
I think this file needs to be split into 3 different files, each having a
```
# REQUIRES: aarch64-registered-target
```
for the respective target at the start.
Otherwise the tests will fail when the respective target is not built.
================
Comment at: llvm/utils/UpdateTestChecks/isel.py:35
+ target_handlers = {
+ }
+ handler = None
----------------
nit: There is one extra space here
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119368/new/
https://reviews.llvm.org/D119368
More information about the llvm-commits
mailing list