[PATCH] D120657: [Flang] NFC: Changes to adhere to coding guidelines

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan marked an inline comment as done.
kiranchandramohan added inline comments.


================
Comment at: flang/lib/Lower/IntrinsicCall.cpp:290
+
+    if (auto fromIntTy{from.dyn_cast<mlir::IntegerType>()})
       if (auto toIntTy{to.dyn_cast<mlir::IntegerType>()}) {
----------------
rovka wrote:
> I think you're actually supposed to use braces here, there's an example in the [[ https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements | LLVM coding style ]] that says "Use braces for the outer `if` since the nested `for` is braced."
> Anyway, I don't feel very strongly about it, so feel free to ignore.
Yes, makes sense and since it is mentioned in the guideline it is better to stick with it. I thought about it but didn't put the effort to check the coding style guide.

I have made the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120657/new/

https://reviews.llvm.org/D120657