[PATCH] D120657: [Flang] NFC: Changes to adhere to coding guidelines

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.


================
Comment at: flang/lib/Lower/IntrinsicCall.cpp:290
+
+    if (auto fromIntTy{from.dyn_cast<mlir::IntegerType>()})
       if (auto toIntTy{to.dyn_cast<mlir::IntegerType>()}) {
----------------
I think you're actually supposed to use braces here, there's an example in the [[ https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements | LLVM coding style ]] that says "Use braces for the outer `if` since the nested `for` is braced."
Anyway, I don't feel very strongly about it, so feel free to ignore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120657/new/

https://reviews.llvm.org/D120657