[compiler-rt] ee95fe5 - [compiler-rt] Disable coverage trace pc guard tests on Thumb

David Spickett via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 28 04:05:41 PST 2022


Author: David Spickett
Date: 2022-02-28T11:56:07Z
New Revision: ee95fe5caa3c32a1a9de6c487bbbc78af837af61

URL: https://github.com/llvm/llvm-project/commit/ee95fe5caa3c32a1a9de6c487bbbc78af837af61
DIFF: https://github.com/llvm/llvm-project/commit/ee95fe5caa3c32a1a9de6c487bbbc78af837af61.diff

LOG: [compiler-rt] Disable coverage trace pc guard tests on Thumb

These are failing on our silent bot:
https://lab.llvm.org/staging/#/builders/162/builds/358

$ <run cmd>
main
foo
bar
baz
SanitizerCoverage: ./sanitizer_coverage_trace_pc_guard-dso.cpp.tmp.2122517.sancov: 2 PCs written
SanitizerCoverage: ./sanitizer_coverage_trace_pc_guard-dso.cpp.tmp_2.so.2122517.sancov: 1 PCs written
SanitizerCoverage: ./sanitizer_coverage_trace_pc_guard-dso.cpp.tmp_1.so.2122517.sancov: 1 PCs written
$ <sancov cmd>
ERROR: Coverage points in binary and .sancov file do not match.

Also reproduces if you build for Thumb on v8 hardware.

Doesn't fail when built with Arm only code so I guess the Thumb mode bit
in the PCs might be the issue.

Added: 
    

Modified: 
    compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cpp
    compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cpp b/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cpp
index 180504ae7ea04..3346d62830adc 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cpp
@@ -1,7 +1,7 @@
 // Tests trace pc guard coverage collection.
 
 // REQUIRES: has_sancovcc
-// UNSUPPORTED: ubsan,powerpc64,s390x
+// UNSUPPORTED: ubsan,powerpc64,s390x,thumb
 // XFAIL: tsan,darwin
 // XFAIL: android && asan
 

diff  --git a/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cpp b/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cpp
index 094a279d35a30..69a6dda694e67 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cpp
@@ -1,7 +1,7 @@
 // Tests trace pc guard coverage collection.
 
 // REQUIRES: has_sancovcc
-// UNSUPPORTED: ubsan,i386-darwin,powerpc64,s390x
+// UNSUPPORTED: ubsan,i386-darwin,powerpc64,s390x,thumb
 // XFAIL: tsan
 // XFAIL: android && asan
 


        


More information about the llvm-commits mailing list