[PATCH] D120000: [1/2] TLS loads opimization (hoist)

Mon Feb 28 03:11:51 PST 2022

lebedev.ri added a comment.

In D120000#3341823 <https://reviews.llvm.org/D120000#3341823>, @xiangzhangllvm wrote:

> In D120000#3341406 <https://reviews.llvm.org/D120000#3341406>, @lebedev.ri wrote:
>
>> What are the legality considerations for this transformation,
>> when is it legal to perform it? I'm mainly confused why it's opt-in.
>
> This only try hoist TLS address call, the TLS variable will only used in thread function, so it is always legal to do this transformation in a function.

What about profitability, is it always a win?

> Sorry, what you mean "opt-in" ?

Why is it not enabled by default?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120000/new/

https://reviews.llvm.org/D120000