[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 27 19:43:53 PST 2022


jrtc27 added inline comments.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:4583
+  if (T.isRISCV() && T.isArch64Bit()) {
+    return "e-m:e-p:64:64-i64:64-i128:128-n32:64-S128";
+  }
----------------
Don't hard-code the data layout, replace the -n64- with -n32:64-, otherwise it's a pain for downstreams like us who change the data layout depending on both the ISA and the ABI. All the other examples in this function (which aren't visible here because you uploaded a diff without context... don't do that) avoid hard-coding data layouts so you have plenty of different examples to copy from.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116735/new/

https://reviews.llvm.org/D116735



More information about the llvm-commits mailing list