[PATCH] D120585: make TargetMachine visible from TargetTransformInfo

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 25 21:20:31 PST 2022


craig.topper added a comment.

It does feel like a bit of a layering violation to expose TargetMachine, which belongs to the Target library, to the Analysis layer. Analysis doesn't depend on Target. It would be considered bad practice to include TargetMachine.h in Analysis. Not sure if the same applies to forward declaration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120585/new/

https://reviews.llvm.org/D120585



More information about the llvm-commits mailing list