[PATCH] D115433: [CommandLine] Reset option to its default if its Default field is undefined

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 25 12:40:14 PST 2022


lattner accepted this revision.
lattner added a comment.
This revision is now accepted and ready to land.

Looks ok to me.  To make code review smoother, I'd recommend making the motivation stronger in the commit message.  Instead of starting by the "what", start by the goal, e.g.:

"Make ResetAllOptionOccurrences work better for xxx by doing YYY; this solves zz problem"

instead of "change low level behavior of something from xx to yy..."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115433/new/

https://reviews.llvm.org/D115433



More information about the llvm-commits mailing list