[PATCH] D120363: [yamlio] Allow parsing an entire mapping as an enumeration

Björn Schäpers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 25 08:36:11 PST 2022


HazardyKnusperkeks added a comment.

In D120363#3344956 <https://reviews.llvm.org/D120363#3344956>, @jhenderson wrote:

> Could you explain more why you can't just update the configuration YAML to use the new format type? I'm not sure we really want to be getting into the business of supporting backwards-compatible YAMLIO code.

In `clang-format` we have an option which is currently an enum. Now @sstwcw  wants to add some functionality to that, where we (as the main `clang-format` developers) said we have to convert the enum into a struct. But don't want to go the way (again) to add the enumerator `Custom` and then a second option with the struct. We would like to have the struct using the name of the current enum, but need to be compatible to the `.clang-format` files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120363/new/

https://reviews.llvm.org/D120363



More information about the llvm-commits mailing list