[PATCH] D119696: [AMDGPU] Improve v_cmpx usage on GFX10.3.

[Thomas Symalla via Phabricator via llvm-commits]

tsymalla marked 4 inline comments as done.
tsymalla added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMasking.cpp:344-345
+
+  // Try to find the last v_cmp instruction that defs the saveexec input
+  // operand.
+  VCmp = findInstrBackwards(
----------------
foad wrote:
> The code just finds the last v_cmp instruction. Then you hope that it defs the saveexec input operand? Do you ever actually check that?
You are correct. I included this check previously but somehow accidentally deleted it during review changes. Good find. Thank you.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119696/new/

https://reviews.llvm.org/D119696