[PATCH] D120556: [flang] Lower power operations

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 25 05:50:34 PST 2022


rovka added a comment.

Shouldn't you also have tests for real :: x, y, z and real(8) :: x, y, z? You don't seem to be covering llvm.pow.f32 and llvm.pow.f64. Also, what happens when you mix real and real(8) base and exponents?



================
Comment at: flang/include/flang/Lower/IntrinsicCall.h:87
+
+/// Generate power function x**y with given the expected
+/// result type.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120556/new/

https://reviews.llvm.org/D120556



More information about the llvm-commits mailing list