[PATCH] D120451: [sancov] Add SPARC support for getPreviousInstructionPc.
Rainer Orth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 25 04:11:01 PST 2022
ro accepted this revision.
ro added a comment.
This revision is now accepted and ready to land.
The patch looks sensible, but isn't actually exercised: I ran a `sparcv9-sun-solaris2.11` build with it included, which made no difference. However, on closer inspection, the `sanitizer_coverage_trace_pc_guard*.cpp` tests didn't run: they aren't supported together with ubsan, while asan isn't supported on SPARC due to a `clang` bug/limitation.
That said, the patch is plausible, so LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120451/new/
https://reviews.llvm.org/D120451
More information about the llvm-commits
mailing list