[PATCH] D119917: [Support] Add CSKY target parser and attributes parser

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 25 01:26:24 PST 2022


DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

LGTM with the redundant tests removed.



================
Comment at: llvm/unittests/Support/CSKYTargetParserTest.cpp:1045
+
+TEST(TargetParserTest, testCSKYExtension) {
+  EXPECT_TRUE(testCSKYExtension("ck801", "trust"));
----------------
zixuan-wu wrote:
> DavidSpickett wrote:
> > What is the purpose of this? Seems like it would be covered by `CSKYCPUTestsPart1`.
> Right. I think it is covered by CSKYCPUTestsPart1 and TargetParserTest::CSKYArchExtFeature below.
Meaning they can be removed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119917/new/

https://reviews.llvm.org/D119917



More information about the llvm-commits mailing list