[PATCH] D120544: [AMDGPU] Omit unnecessary waitcnt before barriers

Austin Kerbow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 25 00:58:57 PST 2022


kerbowa added a comment.

The test waitcnt-vscnt.ll is kind of muddied by this patch. It was relying on the behavior of s_barrier always adding s_waitcnt_vscnt at barriers if there were any outstanding events. The singlethread fences were not actually doing anything. I've added workgroup fences instead. With workgroup fences we currently always add the waitcnt. The test will look as it did before after my memory legalizer/waitcnt overhaul so that these are optimized. Consider this a precommit of this test for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120544/new/

https://reviews.llvm.org/D120544



More information about the llvm-commits mailing list