[PATCH] D120539: [LNT] Removed `0x` checking for offsets in profile assembly

Pavel Kosov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 24 22:40:21 PST 2022


kpdev42 created this revision.
kpdev42 added reviewers: cmatthews, thopre, danilaml.
kpdev42 added a project: LLVM.
Herald added a subscriber: dkolesnichenko.
kpdev42 requested review of this revision.

This logic has been added in https://reviews.llvm.org/D110141 
It seems some objdump implementations do not produce `0x` before hex offsets. 
Assume all regular offsets are hex as before, but relative offsets started with `#` are dec.


Repository:
  rLNT LNT

https://reviews.llvm.org/D120539

Files:
  lnt/server/ui/static/lnt_profile.js


Index: lnt/server/ui/static/lnt_profile.js
===================================================================
--- lnt/server/ui/static/lnt_profile.js
+++ lnt/server/ui/static/lnt_profile.js
@@ -139,7 +139,7 @@
       // and should be processed differently
       var isRelative = addressString.startsWith('#');
       var charOffset = (isRelative ? 1 : 0);
-      var base = (addressString.substring(charOffset).startsWith('0x') ? 16 : 10);
+      var base = (isRelative ? 10 : 16);
       if (isRelative)
           return addressCurrent + parseInt(addressString.substring(1), base);
       else


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120539.411321.patch
Type: text/x-patch
Size: 598 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220225/4fb61d4c/attachment.bin>


More information about the llvm-commits mailing list