[PATCH] D120536: [Sample-PGO] Emit FS discriminators only when -fdebug-info-for-profiling is set
Rong Xu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 24 21:54:03 PST 2022
xur added a comment.
Another way to do this is to check PGOOpt->DebugInfoForProfiling in TargetPassConfig before adding the passes.
That would be the same as IR level addDiscriminator.
But since PGOOpt might not be set for some invocations (like in the unit tests). I would need to introduce
an extra internal option.
I think the change is this patch is simpler.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120536/new/
https://reviews.llvm.org/D120536
More information about the llvm-commits
mailing list