[PATCH] D120528: [BOLT][DWARF] Fix how DW_AT_high_pc [DW_FORM_udata] is handled.
Maksim Panchenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 24 18:01:26 PST 2022
maksfb added inline comments.
================
Comment at: bolt/include/bolt/Core/DebugData.h:540
+ struct DebugPatch32GenericSize : public Patch {
+ DebugPatch32GenericSize(uint32_t O, uint32_t V, uint32_t OVS)
----------------
Could you add a description of the patch kind in a comment?
================
Comment at: bolt/include/bolt/Core/DebugData.h:546
+ }
+ DebugPatchKind getKind() const { return Kind; }
+
----------------
I don't see the need to redefine `getKind()`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120528/new/
https://reviews.llvm.org/D120528
More information about the llvm-commits
mailing list