[PATCH] D120522: [MC][WebAssembly] Fix crash when relocation addend underlows U32
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 24 17:22:14 PST 2022
dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lld/wasm/InputChunks.cpp:119
<< " offset=" << rel.Offset << "\n");
- auto value = file->calcNewValue(rel, tombstone, this);
+ uint64_t value = file->calcNewValue(rel, tombstone, this);
----------------
Would this be the place to put the underflow check? If so, maybe a TODO here as well as in the test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120522/new/
https://reviews.llvm.org/D120522
More information about the llvm-commits
mailing list