[PATCH] D119798: [ADT, CSSPGO] Specify set comparer

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 24 16:42:08 PST 2022


hvdijk marked an inline comment as done.
hvdijk added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/ProfiledCallGraph.h:54
 
-  using iterator = std::set<ProfiledCallGraphEdge>::iterator;
-  using const_iterator = std::set<ProfiledCallGraphEdge>::const_iterator;
+  using iterator =
+      std::set<ProfiledCallGraphEdge, ProfiledCallGraphEdgeComparer>::iterator;
----------------
hoy wrote:
> nit: using iterator = edges::iterator ?
Sure, and if we're doing that we can simplify `edges` at the same time by defining it using `edge`. Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119798/new/

https://reviews.llvm.org/D119798



More information about the llvm-commits mailing list