[PATCH] D120518: const correctness for getTargetTransformInfo

Thu Feb 24 14:19:53 PST 2022

jrtc27 added a comment.

In D120518#3344165 <https://reviews.llvm.org/D120518#3344165>, @arsenm wrote:

> In D120518#3344148 <https://reviews.llvm.org/D120518#3344148>, @jrtc27 wrote:
>
>> This isn't const *correctness*, this is adding a new restriction. The existing code is totally correct, but this potentially makes downstream code no longer correct.
>
> Maintaining state in TTI is definitely bad, so this is a good restriction

Sure, didn't mean to suggest it was a bad change to be making, just that it should be framed accurately rather than in this misleading way (that suggests we currently have a bug)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120518/new/

https://reviews.llvm.org/D120518