[PATCH] D119368: [UpdateLLCTestChecks] Add support for isel debug output in update_llc_test_checks.py

Yatao Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 24 12:21:14 PST 2022


ningxinr added a comment.

In D119368#3340251 <https://reviews.llvm.org/D119368#3340251>, @Flakebi wrote:

> Sorry for taking so long to review this.
>
> I only needed to slightly adjust the regex and it worked fine for amdgpu and x86, so what do you think about returning a default from `get_run_handler` when no target-specific override is found?
>
> The adjusted start regex is
> `r'Selected[\s]*selection[\s]*DAG:[\s]*%bb.0[\s]*\'(?P<func>.*?):[^\']*\'*\n'`
> with a [^\']* after the :. (for amdgpu, an example line is `Selected selection DAG: %bb.0 'test1:main_body'`, for x86 e.g. `Selected selection DAG: %bb.0 'foo:entry'`)

Does the latest version looks like something you had in mind, Sebastian? :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119368/new/

https://reviews.llvm.org/D119368



More information about the llvm-commits mailing list