[PATCH] D114545: [CodeGen] Async unwind - add a pass to fix CFI information

[Daniel Kiss via Phabricator via llvm-commits]

danielkiss accepted this revision.
danielkiss added a comment.
This revision is now accepted and ready to land.

LGMT



================
Comment at: llvm/include/llvm/Target/TargetOptions.h:351
     unsigned PPCGenScalarMASSEntries : 1;
-
+    
     /// Enable JustMyCode instrumentation.
----------------



================
Comment at: llvm/lib/CodeGen/CFIFixup.cpp:103
+  struct BlockFlags {
+    bool StrongNoFrameOnEntry : 1;
+    bool HasFrameOnEntry : 1;
----------------
chill wrote:
> danielkiss wrote:
> > NIT, I'm not sure the bitfield here brings anything in terms of performance vs used memory.
> It brings 200% reduction in the size of an auxiliary data structure (from 3 to 1 byte) and
> we have one entry of these per basic block. At the same time it's extremely cheap
> as coding effort (6 key presses :D)  and does not impact readability in any way: if you
> delete the bitfields, nothing of the rest of the code needs to change.
> 
> Is it a measurable difference? Maybe yes, maybe no, but if no, I will claim the rest of the compiler
> is just written in a sloppy and lazy manner :D
> 
I'm happy with the bitfield just was interested in :D


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114545/new/

https://reviews.llvm.org/D114545