[PATCH] D120455: [CommandLine] Remove `may only occur zero or one times!` error

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 24 09:37:17 PST 2022


MaskRay added a comment.

In D120455#3343416 <https://reviews.llvm.org/D120455#3343416>, @echristo wrote:

> I'd probably prefer that we don't do this since we're looking primarily at options that shouldn't be used outside of development, e.g. clang has a driver that does accept these kinds of things as does lld. Open to arguments for and against though :)

Keep a diagnostic to discourage `-mllvm` users? For 99.9% use cases the user doesn't specify a cl::opt option twice, removing the diagnostic does no discouragement to them.
In the case that a user wants a workaround, the error prevents them from doing so: adding a new driver option and cherry picking a commit into a release is significant hassle for many groups.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120455/new/

https://reviews.llvm.org/D120455



More information about the llvm-commits mailing list