[PATCH] D119816: [SanitizerBounds] Add support for NoSanitizeBounds function

[Marco Elver via Phabricator via llvm-commits]

melver requested changes to this revision.
melver added a comment.
This revision now requires changes to proceed.

Thanks - this looks good so far.



================
Comment at: clang/test/CodeGen/sanitize-coverage.c:56
   // BOUNDS-NOT: call void @__ubsan_handle_out_of_bounds
+  // BOUNDS-NOT: call void @llvm.trap()
   // TSAN-NOT: call void @__tsan_func_entry
----------------
This test by itself is not sufficient, it's technically only for fsanitize-coverage.

2 places with more tests would be good:

1. extend clang/test/CodeGen/bounds-checking.c
2. add a pure IR test in llvm/test/Instrumentation/BoundsChecking

With that, it'll also be very clear what was broken before, and what is being fixed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119816/new/

https://reviews.llvm.org/D119816