[PATCH] D120381: [SPARC] Add isSPARC* in Triple for SPARC

[Xiaodong Liu via Phabricator via llvm-commits]

XiaodongLoong added inline comments.


================
Comment at: llvm/include/llvm/ADT/Triple.h:833
+  /// Tests whether the target is 64-bit SPARC (big endian).
+  bool isSPARC64() const { return getArch() == Triple::sparcv9; }
+
----------------
ro wrote:
> That's the opposite of what I suggested: please follow existing formatting.
I am so sorry. I misunderstood your words. I format back.


================
Comment at: llvm/include/llvm/ADT/Triple.h:836
+  /// Tests whether the target is SPARC.
+  bool isSPARC() const { return isSPARC32() || isSPARC64(); }
+
----------------
ro wrote:
> Same here.
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120381/new/

https://reviews.llvm.org/D120381