[PATCH] D120000: [1/2] TLS loads opimization (hoist)

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/TLSVariableHoist.cpp:168
+BasicBlock::iterator
+TLSVariableHoistPass::findInsertPosInEntry(Function &Fn, tlshoist::TLSCandidate &Cand) {
+  BasicBlock &Entry = Fn.getEntryBlock();
----------------
You need run clang-format for your new code.


================
Comment at: llvm/test/CodeGen/X86/tls.ll:1-8
-; RUN: llc < %s -mtriple=i386-linux-gnu | FileCheck -check-prefix=X86_LINUX %s
-; RUN: llc < %s -mtriple=x86_64-linux-gnu | FileCheck -check-prefix=X64_LINUX %s
-; RUN: llc < %s -mtriple=i386-linux-gnu -fast-isel | FileCheck -check-prefix=X86_ISEL_LINUX %s
-; RUN: llc < %s -mtriple=x86_64-linux-gnu -fast-isel | FileCheck -check-prefix=X64_ISEL_LINUX %s
-; RUN: llc < %s -mtriple=i686-pc-win32 | FileCheck -check-prefix=X86_WIN %s
-; RUN: llc < %s -mtriple=x86_64-pc-win32 | FileCheck -check-prefix=X64_WIN %s
-; RUN: llc < %s -mtriple=i686-pc-windows-gnu | FileCheck -check-prefix=MINGW32 %s
----------------
Why remove the existing test?


================
Comment at: llvm/test/CodeGen/X86/tls.ll:512-513
 
-attributes #0 = { "indirect-tls-seg-refs" }
-attributes #1 = { nounwind "indirect-tls-seg-refs" }
----------------
The existing tests also prefer simple meta data. So remove them in the new test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120000/new/

https://reviews.llvm.org/D120000