[PATCH] D120381: [SPARC] Add isSPARC* in Triple for SPARC
Rainer Orth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 24 04:31:44 PST 2022
ro added inline comments.
================
Comment at: llvm/include/llvm/ADT/Triple.h:833
+ /// Tests whether the target is 64-bit SPARC (big endian).
+ bool isSPARC64() const { return getArch() == Triple::sparcv9; }
+
----------------
That's the opposite of what I suggested: please follow existing formatting.
================
Comment at: llvm/include/llvm/ADT/Triple.h:836
+ /// Tests whether the target is SPARC.
+ bool isSPARC() const { return isSPARC32() || isSPARC64(); }
+
----------------
Same here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120381/new/
https://reviews.llvm.org/D120381
More information about the llvm-commits
mailing list