[PATCH] D120381: [SPARC] Add isSPARC* in Triple for SPARC

[Rainer Orth via Phabricator via llvm-commits]

ro added inline comments.


================
Comment at: llvm/include/llvm/ADT/Triple.h:828
+  /// Tests whether the target is Sparc.
+  bool isSparc() const {
+    return getArch() == Triple::sparc || getArch() == Triple::sparcv9 ||
----------------
XiaodongLoong wrote:
> ro wrote:
> > I'd go for `isSPARC` instead: `SPARC` is an acronym, like `MIPS`, although LLVM is anything but consistent about the correct capitalization.
> Thanks for the comment, I fixed it.
I think all those `clang-format` reformatting suggestions should be ignored: while they might be appropriate for new code, the new methods would be formatted differently from every other one in this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120381/new/

https://reviews.llvm.org/D120381