[PATCH] D97656: [llvm-objcopy] Initial XCOFF32 support.

[ChenZheng via Phabricator via llvm-commits]

shchenz accepted this revision as: shchenz.
shchenz added a comment.

LGTM with one nit. Thanks for adding this support.

Have you tried this patch with objects generated by other tools, like XLC?



================
Comment at: llvm/lib/ObjCopy/XCOFF/XCOFFReader.cpp:45
+
+    Obj.Sections.push_back(ReadSec);
+  }
----------------
Can we use std::move(ReadSec) here to avoid unnecessary copy?


================
Comment at: llvm/lib/ObjCopy/XCOFF/XCOFFReader.cpp:70
+    }
+    Obj.Symbols.push_back(ReadSym);
+  }
----------------
Can we use std::move(ReadSym) here to avoid unnecessary copy?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97656/new/

https://reviews.llvm.org/D97656