[PATCH] D120447: [RISCV] Update some tests to use floating point ABI where it makes sense.

Kito Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 23 22:22:42 PST 2022


kito-cheng accepted this revision.
kito-cheng added a comment.
This revision is now accepted and ready to land.

LGTM, this change dig out few potential ABI implementation bug for half!



================
Comment at: llvm/test/CodeGen/RISCV/fpclamptosat.ll:446
 ; RV32-NEXT:    .cfi_offset ra, -4
+; RV32-NEXT:    fmv.x.w a0, fa0
 ; RV32-NEXT:    call __extendhfsf2 at plt
----------------
This seems wrong for `ilp32d`/`ilp32f` (and also for `lp64d`/`lp64f`) since we should pass half in `fa0`? but I think it's out of scope of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120447/new/

https://reviews.llvm.org/D120447



More information about the llvm-commits mailing list