[PATCH] D120381: [SPARC] Add isSparc for SPARC
Xiaodong Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 23 18:47:17 PST 2022
XiaodongLoong marked an inline comment as done.
XiaodongLoong added inline comments.
================
Comment at: llvm/include/llvm/ADT/Triple.h:828
+ /// Tests whether the target is Sparc.
+ bool isSparc() const {
+ return getArch() == Triple::sparc || getArch() == Triple::sparcv9 ||
----------------
ro wrote:
> I'd go for `isSPARC` instead: `SPARC` is an acronym, like `MIPS`, although LLVM is anything but consistent about the correct capitalization.
Thanks for the comment, I fixed it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120381/new/
https://reviews.llvm.org/D120381
More information about the llvm-commits
mailing list