[PATCH] D120000: [1/2] TLS loads opimization (hoist)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

What are the legality considerations for this transformation,
when is it legal to perform it? I'm mainly confused why it's opt-in.



================
Comment at: llvm/lib/Transforms/Scalar/TLSVariableHoist.cpp:45-52
+static cl::opt<std::string> TLSLoadHoist(
+    "tls-load-hoist",
+    cl::desc(
+        "hoist the TLS loads in PIC model: "
+        "tls-load-hoist=optimize: Eleminate redundant TLS load(s)."
+        "tls-load-hoist=strict: Strictly load TLS address before every use."
+        "tls-load-hoist=non-optimize: Generally load TLS before use(s)."),
----------------
This should be an enum, not strings


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120000/new/

https://reviews.llvm.org/D120000