[PATCH] D120096: PGOInstrumentation, GCOVProfiling: Split indirectbr critical edges regardless of PHIs

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added inline comments.


================
Comment at: llvm/test/Transforms/GCOVProfiling/split-indirectbr-critical-edges.ll:37
+indirect2:
+  ; A 2nd branch to %indirect should make it impossibel to split the edge.
+  indirectbr i8* %2, [label %indirect, label %end]
----------------
modimo wrote:
> nit:s/impossibel/impossible/g
> 
> nit2: If we're willing to change the labels the indirect gotos jump to we can technically split an arbitrary # of edges. Not that we should, of course..
Not completely sure what you mean in "nit2", but I changed the wording to make it clear that this is a trick to keep the edge from getting split so the test keeps working (I know more normalization etc. could "fix" this, but we're only running a single pass here)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120096/new/

https://reviews.llvm.org/D120096